C ffi docs update #146856
C ffi docs update #146856
Conversation
rustbot
added
S-waiting-on-review
|
rustbot has assigned @Mark-Simulacrum. Use |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
lygstate
force-pushed
the
c_ffi_docs_update
branch
from
8431b9d to
8de8b4f
Compare
|
cc @rust-lang/wg-const-eval |
This comment has been minimized.
This comment has been minimized.
lygstate
force-pushed
the
c_ffi_docs_update
branch
from
8de8b4f to
0e8edf1
Compare
lygstate
force-pushed
the
c_ffi_docs_update
branch
from
0e8edf1 to
14ab13f
Compare
… ffi/primitives.rs Split c_ptrdiff_t.md c_size_t.md c_ssize_t.md out of primitives.rs for consistence
lygstate
force-pushed
the
c_ffi_docs_update
branch
from
6ffa9f0 to
001b4f4
Compare
| #[doc = include_str!($Docfile)] | ||
| #[doc(cfg(all()))] | ||
| $( $Cfg )* | ||
| pub type $Alias = $Real; |
There was a problem hiding this comment.
IMO this macro isn't adding enough value to be a macro. It's ~only saving on the repetition of the doc(cfg(all())), but that's not hard to copy/paste across all of these (and why is it needed?)
There was a problem hiding this comment.
maybe we can drop the macro now？ don't know why it introduced at the first place, maybe it's not needed anymore?
There was a problem hiding this comment.
If you'd like to revise this PR to not move things around and keep the old structure, I'd be happy to merge it with just the new docs. (I think that means just keeping the first commit). The separate files are intentional per #136334, though we haven't (yet) made use of that, so I'd prefer to avoid significant refactoring in the shape for now.
Mark-Simulacrum
added
S-waiting-on-author
5 participants
No functional change, just document update